// Copyright 2018 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. // Package mvs implements Minimal Version Selection. // See https://research.swtch.com/vgo-mvs. package mvs import ( "fmt" "sort" "strings" "sync" "sync/atomic" "cmd/go/internal/module" "cmd/go/internal/par" ) // A Reqs is the requirement graph on which Minimal Version Selection (MVS) operates. // // The version strings are opaque except for the special version "none" // (see the documentation for module.Version). In particular, MVS does not // assume that the version strings are semantic versions; instead, the Max method // gives access to the comparison operation. // // It must be safe to call methods on a Reqs from multiple goroutines simultaneously. // Because a Reqs may read the underlying graph from the network on demand, // the MVS algorithms parallelize the traversal to overlap network delays. type Reqs interface { // Required returns the module versions explicitly required by m itself. // The caller must not modify the returned list. Required(m module.Version) ([]module.Version, error) // Max returns the maximum of v1 and v2 (it returns either v1 or v2). // // For all versions v, Max(v, "none") must be v, // and for the target passed as the first argument to MVS functions, // Max(target, v) must be target. // // Note that v1 < v2 can be written Max(v1, v2) != v1 // and similarly v1 <= v2 can be written Max(v1, v2) == v2. Max(v1, v2 string) string // Upgrade returns the upgraded version of m, // for use during an UpgradeAll operation. // If m should be kept as is, Upgrade returns m. // If m is not yet used in the build, then m.Version will be "none". // More typically, m.Version will be the version required // by some other module in the build. // // If no module version is available for the given path, // Upgrade returns a non-nil error. // TODO(rsc): Upgrade must be able to return errors, // but should "no latest version" just return m instead? Upgrade(m module.Version) (module.Version, error) // Previous returns the version of m.Path immediately prior to m.Version, // or "none" if no such version is known. Previous(m module.Version) (module.Version, error) } // BuildListError decorates an error that occurred gathering requirements // while constructing a build list. BuildListError prints the chain // of requirements to the module where the error occurred. type BuildListError struct { Err error stack []buildListErrorElem } type buildListErrorElem struct { m module.Version // nextReason is the reason this module depends on the next module in the // stack. Typically either "requires", or "upgraded to". nextReason string } // Module returns the module where the error occurred. If the module stack // is empty, this returns a zero value. func (e *BuildListError) Module() module.Version { if len(e.stack) == 0 { return module.Version{} } return e.stack[0].m } func (e *BuildListError) Error() string { b := &strings.Builder{} stack := e.stack // Don't print modules at the beginning of the chain without a // version. These always seem to be the main module or a // synthetic module ("target@"). for len(stack) > 0 && stack[len(stack)-1].m.Version == "" { stack = stack[:len(stack)-1] } for i := len(stack) - 1; i >= 1; i-- { fmt.Fprintf(b, "%s@%s %s\n\t", stack[i].m.Path, stack[i].m.Version, stack[i].nextReason) } if len(stack) == 0 { b.WriteString(e.Err.Error()) } else { // Ensure that the final module path and version are included as part of the // error message. if _, ok := e.Err.(*module.ModuleError); ok { fmt.Fprintf(b, "%v", e.Err) } else { fmt.Fprintf(b, "%v", module.VersionError(stack[0].m, e.Err)) } } return b.String() } // BuildList returns the build list for the target module. // The first element is the target itself, with the remainder of the list sorted by path. func BuildList(target module.Version, reqs Reqs) ([]module.Version, error) { return buildList(target, reqs, nil) } func buildList(target module.Version, reqs Reqs, upgrade func(module.Version) (module.Version, error)) ([]module.Version, error) { // Explore work graph in parallel in case reqs.Required // does high-latency network operations. type modGraphNode struct { m module.Version required []module.Version upgrade module.Version err error } var ( mu sync.Mutex modGraph = map[module.Version]*modGraphNode{} min = map[string]string{} // maps module path to minimum required version haveErr int32 ) setErr := func(n *modGraphNode, err error) { n.err = err atomic.StoreInt32(&haveErr, 1) } var work par.Work work.Add(target) work.Do(10, func(item interface{}) { m := item.(module.Version) node := &modGraphNode{m: m} mu.Lock() modGraph[m] = node if v, ok := min[m.Path]; !ok || reqs.Max(v, m.Version) != v { min[m.Path] = m.Version } mu.Unlock() required, err := reqs.Required(m) if err != nil { setErr(node, err) return } node.required = required for _, r := range node.required { work.Add(r) } if upgrade != nil { u, err := upgrade(m) if err != nil { setErr(node, err) return } if u != m { node.upgrade = u work.Add(u) } } }) // If there was an error, find the shortest path from the target to the // node where the error occurred so we can report a useful error message. if haveErr != 0 { // neededBy[a] = b means a was added to the module graph by b. neededBy := make(map[*modGraphNode]*modGraphNode) q := make([]*modGraphNode, 0, len(modGraph)) q = append(q, modGraph[target]) for len(q) > 0 { node := q[0] q = q[1:] if node.err != nil { err := &BuildListError{ Err: node.err, stack: []buildListErrorElem{{m: node.m}}, } for n, prev := neededBy[node], node; n != nil; n, prev = neededBy[n], n { reason := "requires" if n.upgrade == prev.m { reason = "updating to" } err.stack = append(err.stack, buildListErrorElem{m: n.m, nextReason: reason}) } return nil, err } neighbors := node.required if node.upgrade.Path != "" { neighbors = append(neighbors, node.upgrade) } for _, neighbor := range neighbors { nn := modGraph[neighbor] if neededBy[nn] != nil { continue } neededBy[nn] = node q = append(q, nn) } } } // The final list is the minimum version of each module found in the graph. if v := min[target.Path]; v != target.Version { // TODO(jayconrod): there is a special case in modload.mvsReqs.Max // that prevents us from selecting a newer version of a module // when the module has no version. This may only be the case for target. // Should we always panic when target has a version? // See golang.org/issue/31491, golang.org/issue/29773. panic(fmt.Sprintf("mistake: chose version %q instead of target %+v", v, target)) // TODO: Don't panic. } list := []module.Version{target} for path, vers := range min { if path != target.Path { list = append(list, module.Version{Path: path, Version: vers}) } n := modGraph[module.Version{Path: path, Version: vers}] required := n.required for _, r := range required { v := min[r.Path] if r.Path != target.Path && reqs.Max(v, r.Version) != v { panic(fmt.Sprintf("mistake: version %q does not satisfy requirement %+v", v, r)) // TODO: Don't panic. } } } tail := list[1:] sort.Slice(tail, func(i, j int) bool { return tail[i].Path < tail[j].Path }) return list, nil } // Req returns the minimal requirement list for the target module // that results in the given build list, with the constraint that all // module paths listed in base must appear in the returned list. func Req(target module.Version, list []module.Version, base []string, reqs Reqs) ([]module.Version, error) { // Note: Not running in parallel because we assume // that list came from a previous operation that paged // in all the requirements, so there's no I/O to overlap now. // Compute postorder, cache requirements. var postorder []module.Version reqCache := map[module.Version][]module.Version{} reqCache[target] = nil var walk func(module.Version) error walk = func(m module.Version) error { _, ok := reqCache[m] if ok { return nil } required, err := reqs.Required(m) if err != nil { return err } reqCache[m] = required for _, m1 := range required { if err := walk(m1); err != nil { return err } } postorder = append(postorder, m) return nil } for _, m := range list { if err := walk(m); err != nil { return nil, err } } // Walk modules in reverse post-order, only adding those not implied already. have := map[module.Version]bool{} walk = func(m module.Version) error { if have[m] { return nil } have[m] = true for _, m1 := range reqCache[m] { walk(m1) } return nil } max := map[string]string{} for _, m := range list { if v, ok := max[m.Path]; ok { max[m.Path] = reqs.Max(m.Version, v) } else { max[m.Path] = m.Version } } // First walk the base modules that must be listed. var min []module.Version for _, path := range base { m := module.Version{Path: path, Version: max[path]} min = append(min, m) walk(m) } // Now the reverse postorder to bring in anything else. for i := len(postorder) - 1; i >= 0; i-- { m := postorder[i] if max[m.Path] != m.Version { // Older version. continue } if !have[m] { min = append(min, m) walk(m) } } sort.Slice(min, func(i, j int) bool { return min[i].Path < min[j].Path }) return min, nil } // UpgradeAll returns a build list for the target module // in which every module is upgraded to its latest version. func UpgradeAll(target module.Version, reqs Reqs) ([]module.Version, error) { return buildList(target, reqs, func(m module.Version) (module.Version, error) { if m.Path == target.Path { return target, nil } return reqs.Upgrade(m) }) } // Upgrade returns a build list for the target module // in which the given additional modules are upgraded. func Upgrade(target module.Version, reqs Reqs, upgrade ...module.Version) ([]module.Version, error) { list, err := reqs.Required(target) if err != nil { return nil, err } // TODO: Maybe if an error is given, // rerun with BuildList(upgrade[0], reqs) etc // to find which ones are the buggy ones. list = append([]module.Version(nil), list...) list = append(list, upgrade...) return BuildList(target, &override{target, list, reqs}) } // Downgrade returns a build list for the target module // in which the given additional modules are downgraded. // // The versions to be downgraded may be unreachable from reqs.Latest and // reqs.Previous, but the methods of reqs must otherwise handle such versions // correctly. func Downgrade(target module.Version, reqs Reqs, downgrade ...module.Version) ([]module.Version, error) { list, err := reqs.Required(target) if err != nil { return nil, err } max := make(map[string]string) for _, r := range list { max[r.Path] = r.Version } for _, d := range downgrade { if v, ok := max[d.Path]; !ok || reqs.Max(v, d.Version) != d.Version { max[d.Path] = d.Version } } var ( added = make(map[module.Version]bool) rdeps = make(map[module.Version][]module.Version) excluded = make(map[module.Version]bool) ) var exclude func(module.Version) exclude = func(m module.Version) { if excluded[m] { return } excluded[m] = true for _, p := range rdeps[m] { exclude(p) } } var add func(module.Version) add = func(m module.Version) { if added[m] { return } added[m] = true if v, ok := max[m.Path]; ok && reqs.Max(m.Version, v) != v { exclude(m) return } list, err := reqs.Required(m) if err != nil { // If we can't load the requirements, we couldn't load the go.mod file. // There are a number of reasons this can happen, but this usually // means an older version of the module had a missing or invalid // go.mod file. For example, if example.com/mod released v2.0.0 before // migrating to modules (v2.0.0+incompatible), then added a valid go.mod // in v2.0.1, downgrading from v2.0.1 would cause this error. // // TODO(golang.org/issue/31730, golang.org/issue/30134): if the error // is transient (we couldn't download go.mod), return the error from // Downgrade. Currently, we can't tell what kind of error it is. exclude(m) } for _, r := range list { add(r) if excluded[r] { exclude(m) return } rdeps[r] = append(rdeps[r], m) } } var out []module.Version out = append(out, target) List: for _, r := range list { add(r) for excluded[r] { p, err := reqs.Previous(r) if err != nil { // This is likely a transient error reaching the repository, // rather than a permanent error with the retrieved version. // // TODO(golang.org/issue/31730, golang.org/issue/30134): // decode what to do based on the actual error. return nil, err } // If the target version is a pseudo-version, it may not be // included when iterating over prior versions using reqs.Previous. // Insert it into the right place in the iteration. // If v is excluded, p should be returned again by reqs.Previous on the next iteration. if v := max[r.Path]; reqs.Max(v, r.Version) != v && reqs.Max(p.Version, v) != p.Version { p.Version = v } if p.Version == "none" { continue List } add(p) r = p } out = append(out, r) } return out, nil } type override struct { target module.Version list []module.Version Reqs } func (r *override) Required(m module.Version) ([]module.Version, error) { if m == r.target { return r.list, nil } return r.Reqs.Required(m) }